Skip to content

refactor(core): report capability audit facts directly - #3815

Open
joebasrawi wants to merge 1 commit into
apache:mainfrom
joebasrawi:refactor/capability-audit-facts
Open

refactor(core): report capability audit facts directly#3815
joebasrawi wants to merge 1 commit into
apache:mainfrom
joebasrawi:refactor/capability-audit-facts

Conversation

@joebasrawi

Copy link
Copy Markdown

Summary

The capability audit was using permission labels for things that are not permissions.

This removes that mapping and reports the actual facts instead: whether a skill declares tools and the real status of each scheduled task. It also renames executableScheduledTaskCount to activeScheduledTaskCount.

Fixes #3386

Verification

  • All 657 core tests passed
  • Lint and formatting passed
  • Affected builds and type-checks passed
  • UI dependency and ASF header checks passed
  • I tried the full UI suite, but the local Node test runner hung in existing DOM tests after 178 passed. I am not counting that suite as passing
  • I did not run the full repository test suite

AI use

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope:

Codex helped implement the refactor, add the regression test, update the Storybook fixture, and run the checks.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes, described above
  • No

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update on dd0d77325d:

GO (conditional) — no P0-P3. Replaces fabricated permission labels with direct hasDeclaredTools/status facts; semantic equal via exhaustive states (active scheduled == executable). Test green. Note: exact head currently has no CI runs — needs green before merge.

简体中文该头无阻断,待 CI。

@M4n5ter
M4n5ter force-pushed the refactor/capability-audit-facts branch from dd0d773 to e5e3d69 Compare August 26, 2026 08:58
@M4n5ter
M4n5ter force-pushed the refactor/capability-audit-facts branch from e5e3d69 to d3fa098 Compare August 26, 2026 09:56
@github-actions github-actions Bot added the effort/M Under 500 readable lines label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/M Under 500 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(core): capability audit encodes scheduled-task status as a fake permission mode

2 participants